Skip to content

Add C++ driver support#989

Merged
auphelia merged 67 commits intoXilinx:devfrom
LinusJungemann:feature/integrateCppDriver
May 26, 2025
Merged

Add C++ driver support#989
auphelia merged 67 commits intoXilinx:devfrom
LinusJungemann:feature/integrateCppDriver

Conversation

@LinusJungemann
Copy link

@LinusJungemann LinusJungemann commented Feb 21, 2024

Adds support for the C++ driver for FINN https://github.com/eki-project/finn-cpp-driver
The C++ driver itself is added as a submodule to FINN.

Current v1.0 driver release note: https://github.com/eki-project/finn-cpp-driver/releases/tag/v1.0

fpjentzsch and others added 30 commits August 1, 2023 18:39
@fpjentzsch
Add Singularity support to existing run script
ef412d9
@fpjentzsch
Add GHA to build & test singularity container
8adee81
@fpjentzsch
[Singularity] Add documentation
39e88cd
@fpjentzsch
[Singularity] Fixes for GHA
7d7d061
@fpjentzsch
[Singularity] Fixes for GHA
ed1a325
@fpjentzsch
[Singularity] Increase build space for GHA
5aa85d0
@fpjentzsch
[Singularity] Adjust build space for GHA
71259c5
@fpjentzsch
[Singularity] GHA fixes
3ed04b8
@fpjentzsch
[Singularity] Adjust GHA
8f263bc
@fpjentzsch
[Singularity] Adjust GHA
be61c31
@fpjentzsch
[Singularity] Adjust GHA
a61ac9b
@fpjentzsch
Merge remote-tracking branch 'upstream/dev' into feature/apptainer
c80c03c
@bwintermann
Skeleton for C driver generation
cbf9f48
@bwintermann
Creating templates for C and C++ drivers
f0bdea2
@bwintermann
C++ kernel wip
634ef9f
@bwintermann
Fixes for C++ driver
24a8066
@bwintermann
Fixes for driver creation
201011a
@bwintermann
C++ driver buffers and memory initialization
60640dd
@bwintermann
Compilation fix
c0b390c
@bwintermann
Inclusion of cpp drivers per submodule. Fixes for MakeCPPDriver
89e3ff3
@bwintermann
Fixes for c++ driver generation
820e8f8
@bwintermann
Fixed driver export
ea554b5
@bwintermann
Temporary debugging print statements
c5225e1
@bwintermann
Updated to write out header and config files for updated cpp driver
50b04d2
@bwintermann
Updated finn-cpp-driver submodule to track dev branch
2145749
@bwintermann
Some path fixing
b5aaa2d
@bwintermann
Transfer run-docker update for singularity from PR
cacbd55
@bwintermann
Fixed path errors during cpp driver step
7c39ad5
@bwintermann
Fixed pathing issues and type name conversion
9b521f5
@bwintermann
Datatype parser fix
1e2aea6
@LinusJungemann
Copy link
Author

LinusJungemann commented Mar 14, 2025

The C++ driver depends on #1210, so that I do not have to duplicate some of the builder options. In the meantime, there are still some details that I will polish up a bit for nicer integration.

I have now moved both drivers into a single step called step_make_driver. If pynq_driver is in the generate_outputs list, then the old driver will be used. If cpp_driver is in the list, then the C++ driver is used. Additionally, the C++ driver version can be selected in the build config using "latest" or a commit hash.

preusser
preusser approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@preusser preusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LinusJungemann!
This looks good.

fpjentzsch added a commit to eki-project/finn-plus that referenced this pull request May 10, 2025
@LinusJungemann @fpjentzsch
@bwintermann @auphelia
Integrate C++ driver (#62)
fc77b8e 
* See also Xilinx#989

---------

Co-authored-by: Felix Jentzsch <felix.jentzsch@upb.de>
Co-authored-by: bwintermann <bjarne.wintermann@me.com>
Co-authored-by: auphelia <jakobapk@web.de>
@auphelia auphelia removed the request for review from STFleming May 26, 2025 13:32
auphelia
auphelia approved these changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @LinusJungemann! Looks good to me as well :) I've added some small changes on code organization, tests and added the --force flag to the xclbinutil command to make it easier to re-run.

@auphelia auphelia merged commit 71c35c5 into Xilinx:dev May 26, 2025
2 checks passed
preusser
preusser reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@preusser preusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Linus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auphelia auphelia auphelia approved these changes

+1 more reviewer

@preusser preusser preusser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LinusJungemann @auphelia @preusser @fpjentzsch @bwintermann