Skip to content

fix typo foudationWalletAddr for testnet#245

Open
gzliudan wants to merge 1 commit intoXinFinOrg:masterfrom
gzliudan:fix-testnet-foudation
Open

fix typo foudationWalletAddr for testnet#245
gzliudan wants to merge 1 commit intoXinFinOrg:masterfrom
gzliudan:fix-testnet-foudation

Conversation

@gzliudan
Copy link
Contributor

@gzliudan gzliudan commented Feb 28, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Corrected a spelling error in a genesis configuration field name.
  • Style

    • Removed unnecessary blank line formatting.

Ref: XinFinOrg/XDPoSChain#2063

@coderabbitai
Copy link

coderabbitai bot commented Feb 28, 2026

📝 Walkthrough

Walkthrough

A typo in the testnet genesis configuration file is corrected by renaming the misspelled field "foudationWalletAddr" to "foundationWalletAddr", with no functional or value changes accompanying the field name correction.

Changes

Cohort / File(s) Summary
Configuration Typo Fix
testnet/genesis.json
Corrected field name from "foudationWalletAddr" to "foundationWalletAddr" and removed extraneous blank line. No value or semantic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a typo caught,
"Foudation" wasn't what we sought,
With careful paws, the fix is done,
"Foundation" shines—our work is fun! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing a typo in a field name from 'foudationWalletAddr' to 'foundationWalletAddr' in the testnet genesis configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@testnet/genesis.json`:
- Line 16: The devnet and mainnet genesis JSON files still use the misspelled
key "foudationWalletAddr"; update those files so the key is spelled
"foundationWalletAddr" (exactly matching the corrected key in testnet) while
keeping the associated wallet address value unchanged, and search the repository
for any other occurrences of "foudationWalletAddr" to replace with
"foundationWalletAddr" to ensure consistency.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c21916 and a6b3e34.

📒 Files selected for processing (1)
  • testnet/genesis.json

"rewardCheckpoint": 900,
"gap": 450,
"foudationWalletAddr": "xdc746249c61f5832c5eed53172776b460491bdcd5c"
"foundationWalletAddr": "xdc746249c61f5832c5eed53172776b460491bdcd5c"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for references to both field name variants and related code

echo "=== Searching for 'foundationWalletAddr' (correct spelling) ==="
rg -n 'foundationWalletAddr' --max-count=20

echo ""
echo "=== Searching for 'foudationWalletAddr' (misspelled version) ==="
rg -n 'foudationWalletAddr' --max-count=20

echo ""
echo "=== Searching for 'foundation' in genesis-related code ==="
rg -n 'foundation' -i --type go --type json -B2 -A2 | head -50

echo ""
echo "=== Finding all genesis JSON files ==="
find . -name 'genesis.json' -type f 2>/dev/null

Repository: XinFinOrg/XinFin-Node

Length of output: 914


🏁 Script executed:

#!/bin/bash
# Search for Go struct definitions that map genesis JSON fields

echo "=== Searching for Genesis struct definitions ==="
rg -n 'type.*Genesis' --type go -A 30 | head -100

echo ""
echo "=== Searching for JSON struct tags related to genesis ==="
rg -n 'json:".*Wallet' --type go -B2 -A2

echo ""
echo "=== Searching for any code that reads/parses genesis files ==="
rg -n 'genesis\.json' --type go -B2 -A2

echo ""
echo "=== Check Go files in root and common directories ==="
find . -maxdepth 3 -name '*.go' -type f | head -20

Repository: XinFinOrg/XinFin-Node

Length of output: 755


🏁 Script executed:

#!/bin/bash
# Understand repository structure

echo "=== Repository structure ==="
ls -la | head -20

echo ""
echo "=== File types in repository ==="
find . -type f -name '*.go' -o -name '*.js' -o -name '*.sol' -o -name '*.py' -o -name '*.java' 2>/dev/null | head -20

echo ""
echo "=== Check if there are any subdirectories that might contain code ==="
ls -d */ 2>/dev/null | head -20

echo ""
echo "=== Total files in repository ==="
git ls-files | wc -l

echo ""
echo "=== List all files to understand the repo ==="
git ls-files | head -50

Repository: XinFinOrg/XinFin-Node

Length of output: 2334


🏁 Script executed:

#!/bin/bash
# Check if the address creator code references foundationWalletAddr or genesis fields

echo "=== Checking address-creator.js for references ==="
cat -n address-creator/address-creator.js | grep -i 'foundation\|wallet\|genesis' || echo "No matches found"

echo ""
echo "=== Full address-creator.js content ==="
cat -n address-creator/address-creator.js

Repository: XinFinOrg/XinFin-Node

Length of output: 1636


Fix the typo in devnet and mainnet genesis files as well.

The spelling correction is correct, but the fix is incomplete. The misspelled field foudationWalletAddr remains in both devnet/genesis.json:16 and mainnet/genesis.json:16. Apply the same correction to all three genesis files for consistency:

  • testnet/genesis.json:16 ✓ (corrected)
  • devnet/genesis.json:16 (needs fix: foudationWalletAddrfoundationWalletAddr)
  • mainnet/genesis.json:16 (needs fix: foudationWalletAddrfoundationWalletAddr)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@testnet/genesis.json` at line 16, The devnet and mainnet genesis JSON files
still use the misspelled key "foudationWalletAddr"; update those files so the
key is spelled "foundationWalletAddr" (exactly matching the corrected key in
testnet) while keeping the associated wallet address value unchanged, and search
the repository for any other occurrences of "foudationWalletAddr" to replace
with "foundationWalletAddr" to ensure consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants