Repository navigation
Conversation
…4-group-unlimited-discussion,纯 rename)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景与目标
修复群聊
everyone模式「每轮全员各说一句就停、必须用户再发言」的产品缺口(issue #333)。保留单轮形态,新增「无限讨论链」形态:成员自动连续多轮讨论,直到某轮全员静默自然收敛或用户点停止讨论;仅everyone生效,单轮模式行为与事件逐字段不变。交付内容
discussion_mode = single(默认)/unlimited(仅everyone合法;非法组合 REST 400:invalid_discussion_mode/discussion_mode_requires_everyone),room.json缺字段按single向后兼容。agent/team/orchestrator.py):一轮正常结束且有人发言 → 自动续轮(每轮全员各一次、可[PASS]);收敛=本轮 0 发言且无未消费用户消息;用户插话不打断链、@插当前位次/下一轮;链级互斥覆盖整条链。stop_discussion+ RESTPOST /api/team/rooms/{room_id}/discussion/stop,幂等;单轮不提供(保持三出口)。team.discussion_max_rounds=200/discussion_max_turns=600/discussion_max_seconds=6000,链启动快照、改配置需重启;非法值ConfigErrorfail-fast。discussion_started/system_entry/discussion_stop_requested/discussion_ended,round_ended扩展chain_id/round_index/chain_continues/termination=stopped;single四键不变;前端按chain_id守卫、room_state.discussion_round/discussion_reason重连恢复。docs/architecture.md/CONTEXT.md/ 面试讲稿同步;asterwynd.example.yaml增team:示例。OpenSpec 生命周期
openspec/changes/archive/2026-10-24-group-unlimited-discussion/(backlog 已移除,workflow-events.jsonl含current_spec_synced/backlog_updated/change_archived)reviews/building-review.md,无 medium+,15 条 low/nit 登记不阻塞);三份 witnessloop manifest 已用归档目录名重建。验证
tests/agent/team/test_orchestrator.py84 passed;tests/agent/team + test_config + test_team_store195 passed;tests/web_tests679 passed / 9 skipped(含 2 个真实 Chromium 新增用例)。uv run pytest -q --deselect tests/agent/tools/test_cgroup.py→ 4354 passed / 145 failed / 46 skipped;与 master 基线(604b56c)失败集逐条 diff 完全一致(145 个均为 Windows 环境预存在项),新增用例全绿(基线 4247 passed)。本地 deselect 原因:test_cgroup.py在 Windows 上os.kill(pid, 0)走 TerminateProcess 会杀 pytest 进程(基线同样,Linux CI 全量覆盖)。npx --yes @fission-ai/openspec@1.4.1 validate --all --strict→ 28 passed / 0 failed;uv run python scripts/check_openspec_artifacts.py --base-ref origin/master --require-base→ Project rule checks passed。测试计划
discussion_*负向断言)round_limit、未消费消息强制续轮chain_id单调与前端守卫、room_state重连恢复、390px 布局