fix(extract): close dar stdin to avoid BrokenPipeError at GC#25
Merged
Conversation
The ESC-feeder daemon thread kept proc.stdin's TextIOWrapper alive past dar's exit. The wrapper's finalizer flushed buffered bytes into the now-dead pipe, surfacing a BrokenPipeError after the extract summary banner. Close stdin explicitly in a finally and suppress the expected pipe error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_sequentialleftproc.stdinopen after dar exited; the ESC-feeder daemon thread kept theTextIOWrapperalive, and Python's finalizer later raisedBrokenPipeErrorflushing buffered bytes into the dead pipe.proc.stdinin afinallyand suppress the expectedBrokenPipeError/OSError, so the cancel path and the normal completion path both end cleanly.Test plan
bd-archive extractagainst a complete disc set and confirm noException ignored while finalizing fileappears after the dar summary.🤖 Generated with Claude Code