Bump three modules with reachable vulnerabilities - #62
Merged
Merged
Conversation
govulncheck found four, all reached from Pylon's own HTTP calls rather than
merely present in the module graph:
GO-2026-5970 x/text infinite loop on invalid input
GO-2026-4918 x/net infinite loop in the HTTP/2 transport on a bad
SETTINGS_MAX_FRAME_SIZE
GO-2026-5026 x/net IDNA fails to reject ASCII-only Punycode labels
GO-2026-6061 grpc xDS RBAC engine and HTTP/2 server
The traces run through feedback.Submit's POST and the Google consent server,
which is what made them reachable. pylon-ui carried older x/net and x/text as
indirect dependencies and govulncheck did not consider it affected — they are
bumped anyway so the two modules do not drift, and `make gui` still builds.
govulncheck ./... now reports zero for both modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
govulncheckfound four vulnerabilities that Pylon's own code path reaches — not merely present in the module graph, but called:golang.org/x/textgolang.org/x/netSETTINGS_MAX_FRAME_SIZEgolang.org/x/netgoogle.golang.org/grpcThe traces run through
feedback.Submit's POST and the Google consent server, which is what makes them reachable rather than theoretical.pylon-uicarried olderx/netandx/textas indirect dependencies. govulncheck did not consider that module affected — the vulnerable paths are not reached there — but they are bumped anyway so the two modules do not drift, andmake guistill builds.Verification
go test ./...,pylon-ui's tests andmake guiall pass.Found during a full-codebase security review; the other findings from it are separate PRs.
🤖 Generated with Claude Code