Conversation
- Introduced `FeatureFlags` enum with a static variable `disableDownloads` to control the visibility of downloads-related UI elements. - Updated `PersonalView` to conditionally display the downloads tab and its content based on the `disableDownloads` flag. - Modified `SettingsView` to conditionally show the download settings toggle and delete downloads button only when downloads are enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature flag to allow disabling the downloads functionality throughout the app. The flag is used to conditionally hide or disable all UI elements and logic related to downloads.
Feature flag implementation and conditional UI updates:
FeatureFlags.disableDownloadsstatic boolean indisableDownloads.swiftto control the visibility and availability of downloads features.Conditional rendering in views:
MediathekDetailView.swiftto hide the download menu when downloads are disabled by checking the feature flag. [1] [2]PersonalView.swiftto conditionally show the downloads tab andDownloadsListViewonly if downloads are enabled, and to handle navigation to the downloads tab appropriately based on the flag. [1] [2]SettingsView.swiftto hide the "Download over WiFi only" toggle and related settings when downloads are disabled. [1] [2]