Fix image background on multiple screenshots and add text shadow#33
Open
russnem wants to merge 1 commit into
Open
Fix image background on multiple screenshots and add text shadow#33russnem wants to merge 1 commit into
russnem wants to merge 1 commit into
Conversation
- Fix bug where image backgrounds couldn't be applied to more than one screenshot by storing imageSrc data URL alongside the Image object, reconstructing it after deep copies and IndexedDB round-trips, and resetting the file input after upload - Add text shadow controls (color, blur, opacity, distance X/Y) as a collapsible toggle section in the Text tab, applied to both headline and subheadline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imageobject was lost during deep copies (JSON.parse/stringify) and IndexedDB serialization. Fixed by storing the data URL asimageSrcalongside the object and reconstructing it after round-trips. Also reset the file input after upload so the same file can be re-selected.Test plan