This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1594] Refactor Requirements Controller Spec - #1619
Open
esoterik wants to merge 2 commits into
Open
Conversation
esoterik
force-pushed
the
1594_refactor_req_controller_spec
branch
from
August 9, 2016 14:16
b9ce89b to
e23bf23
Compare
zeffman
suggested changes
Feb 25, 2017
| sign_in FactoryGirl.create(:user) | ||
| get :show, id: @requirement | ||
| expect(response).to redirect_to(root_url) | ||
| end |
Contributor
There was a problem hiding this comment.
why is testing for show removed?
| sign_in FactoryGirl.create(:admin) | ||
| get :edit, id: @requirement | ||
| end | ||
| it 'should set @requirement to the selected requirement' do |
Contributor
There was a problem hiding this comment.
I assume removed because the route doesn't get used?
| mock_user_sign_in | ||
| put :update, id: 1, requirement: { contact_name: 'Name' } | ||
| end | ||
| it_behaves_like 'redirected request' |
Contributor
There was a problem hiding this comment.
this doesn't check permissions, since a successful request will also redirect
| mock_user_sign_in | ||
| delete :destroy, id: 1 | ||
| end | ||
| it_behaves_like 'redirected request' |
Contributor
There was a problem hiding this comment.
also doesn't check permissions, for same reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1594