This repository was archived by the owner on Jul 24, 2020. It is now read-only.
[1223] Expand integration test suite - #1635
Open
esoterik wants to merge 9 commits into
Open
Conversation
added 9 commits
July 22, 2016 08:41
esoterik
commented
Sep 26, 2016
| expect(page).to have_content 'Confirm Reservation Request' | ||
| end | ||
| end | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
these aren't necessary
esoterik
commented
Sep 26, 2016
| renewal_days_before_due: 5 }.freeze | ||
| ATTRS.each { |attr, value| it_behaves_like 'can update', attr, value } | ||
| end | ||
| describe 'deactivation' do |
Collaborator
Author
There was a problem hiding this comment.
the only specs that are worth keeping for categories / models / items are deactivation, but it's currently pretty hard to test due to how our modals work
esoterik
commented
Sep 26, 2016
| @@ -0,0 +1,58 @@ | |||
| require 'spec_helper' | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
these are probably worth keeping
esoterik
commented
Sep 26, 2016
| @@ -0,0 +1,50 @@ | |||
| require 'spec_helper' | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
should cross check this with the open PR for reports spec
esoterik
commented
Sep 26, 2016
| expect(user.requirements).to include(req) | ||
| end | ||
| end | ||
| context 'reservation creation' do |
Collaborator
Author
There was a problem hiding this comment.
probably just keep this spec
esoterik
commented
Sep 26, 2016
| @@ -0,0 +1,56 @@ | |||
| # frozen_string_literal: true | |||
| require 'spec_helper' | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
probably worth keeping -- more complex permissions + functionality
cross check with controller / unit tests to really determine this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't cover the full scope of the issue, but it adds more integration tests.
We should figure out which of these are necessary.
If we decide to keep deactivation integration tests, I would appreciate some help figuring out how to assert that two modals follow each other -- the tests fail right now and are commented out.