This repository was archived by the owner on Nov 29, 2017. It is now read-only.
Multi-Queries - #6
Closed
mrosales wants to merge 3 commits into
Closed
Conversation
Queries can now be either arrays or hashes. If the query is an array, all of the children must be hashes, and the query will be the result of joining all of the children with "^OR".
Code checks for an incident with empty attributes to denote failure, but the constructor failed instead. This caused errors whenever a query returned no results. Now works as intended
Can use `is_closed?`, `is_resolved?` and `is_open?` to determine the state of an incident
Contributor
|
Thanks Micah!
|
|
Let me know if you need any help in terms of ServiceNow capabilities and how to pull data out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
Incident.whereto accept an array of hashes as well as just a single hash. When an array is specified, it joins all of the individual hash queries with ORs and then returns an array of incidents matching the entire query.Also added a couple macros for incident state.
Can now use
is_closed?,is_resolved?andis_open?on incident objects