[257] Add suite unmerging - #594
Open
esoterik wants to merge 1 commit into
Open
Conversation
Resolves #257 - Adds SuiteUnmerger - Adds original suite attribute to rooms - Adds Room#store_original_suite!
esoterik
commented
Apr 15, 2017
| result = described_class.submit(suite: suite, params: params) | ||
| expect(result[:object].draws.map(&:id)).to include(draw.id) | ||
| end | ||
| it 'calls :store_original_suite! on the rooms' do |
Collaborator
Author
There was a problem hiding this comment.
@orenyk I have no idea why this is failing.
| # @params [Hash] attrs Other attributes to update | ||
| # | ||
| # @return [Boolean] Whether or not the update was successful | ||
| def store_original_suite!(**attrs) |
Contributor
There was a problem hiding this comment.
What would happen if a suite is merged, unmerged, merged again, then unmerged again? It seems like the suite would be left with outdated info in the :original_suite attribute.
Collaborator
Author
There was a problem hiding this comment.
We want the original suite to always be the first suite the rooms belongs into, so once this attribute is set it shouldn't change.
In that scenario, original_suite would always be the room's first suite, not any of the ones that it belonged to during previous merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #257