Vechile routing#35
Merged
Merged
Conversation
added 9 commits
May 13, 2026 01:52
AhmedAdelWafdy7
requested changes
Jun 29, 2026
AhmedAdelWafdy7
left a comment
AhmedAdelWafdy7
left a comment
Collaborator
There was a problem hiding this comment.
We just need to remove log files before mrege.
Collaborator
There was a problem hiding this comment.
Can you add this to .gitignore
Collaborator
There was a problem hiding this comment.
Add this to .gitignore or delete entirely. Also where is this output comes from ?
Collaborator
Author
There was a problem hiding this comment.
this generated from the command ros2 run tf2_tools view_frames
this tool listen to TF data and writes frames.pdf and frame.gv
Collaborator
There was a problem hiding this comment.
Okay I think it's not needed if it's a debugging output.
AhmedAdelWafdy7
requested changes
Jul 2, 2026
AhmedAdelWafdy7
left a comment
AhmedAdelWafdy7
left a comment
Collaborator
There was a problem hiding this comment.
Revert changes in proto cmake to pass CI
| find_package(PkgConfig REQUIRED) | ||
| find_package(OpenMP REQUIRED) | ||
| find_package(protobuf CONFIG REQUIRED) | ||
| # find_package(protobuf CONFIG REQUIRED) |
Collaborator
There was a problem hiding this comment.
try to revert this change to pass cmake
AhmedAdelWafdy7
requested changes
Jul 4, 2026
Collaborator
|
@AlaaHassan54 All good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.