Skip to content

fix: distinguish demo assumptions from workflow facts - #5

Merged
Yasuui merged 6 commits into
mainfrom
codex/proof-readiness-20261026
Oct 27, 2026
Merged

Yasuui merged 6 commits into
mainfrom
codex/proof-readiness-20261026

Conversation

@Yasuui

@Yasuui Yasuui commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

This merged change corrects the demo's evidence labels and workflow-step extraction, and adds request validation, lint fixes, CI and documentation. The later automation-plan work is tracked separately in #9.

This description was reconstructed after it was inadvertently replaced during the follow-up; it is not the original PR description.

@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
workflow-friction-mapper Ready Ready Preview Oct 26, 2026 6:32pm UTC

@Yasuui
Yasuui marked this pull request as ready for review October 26, 2026 17:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T18:32:09.874625Z
We couldn’t complete this review. Comment @codex review to try again.
32d25c8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

- MapperFace reads reduced motion through useSyncExternalStore and derives
  the blink instead of resetting state inside an effect.
- WorkflowChat sends the intent per request, opens the brief from onFinish,
  and tracks streamed chunks during render instead of in an effect.
- factsAndAssumptions de-duplicates evidence lines, so React keys stay unique
  and the brief no longer repeats a line.
- Rendered-HTML tests now assert the current greeting and the data: URL
  download path that replaced blob URLs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmD6cAA88NEhhUnPW3ew9
The route parsed the raw body with req.json() and forwarded whatever arrived:
any role (system included), any part type, remote file URLs and unbounded
sizes. Malformed JSON surfaced as a 500.

- lib/optimize-request.ts checks content type, body size (4 MB), message
  count, text length, file count, roles (user/assistant), part types, and
  inline data: attachments against one allowlist shared with the composer.
  Assistant history keeps only text parts. Rejections are 400/413/415 with a
  message the chat shows to the user.
- The composer normalizes attachment media types, refuses unsupported images
  and caps PDFs and images at 2.5 MB before upload.
- tests/optimize-request.test.mjs covers the UI's real payloads, injection of
  system turns, SSRF-style remote URLs, mislabelled binaries and size limits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmD6cAA88NEhhUnPW3ew9
- GitHub Actions runs lint, then tsc, next build and node --test, with no
  model key.
- README states what is live (demo mode), what is built but off (live model),
  what the tests cover and what they do not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmD6cAA88NEhhUnPW3ew9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmD6cAA88NEhhUnPW3ew9
The earlier capture came from next dev and showed development issue badges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbmD6cAA88NEhhUnPW3ew9
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@Yasuui Yasuui changed the title fix: distinguish demo assumptions from workflow facts Make the mapper verifiable: honest evidence, request guard, clean lint and CI Oct 26, 2026
@Yasuui
Yasuui merged commit 32d25c8 into main Oct 27, 2026
3 checks passed
@Yasuui Yasuui changed the title Make the mapper verifiable: honest evidence, request guard, clean lint and CI feat: turn workflow analysis into a build plan Oct 28, 2026
@Yasuui Yasuui changed the title feat: turn workflow analysis into a build plan fix: distinguish demo assumptions from workflow facts Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 32d25c89 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants