Repository navigation
Fix design-review findings: contrast, overlay focus, touch targets, brief wait - #8
Merged
Merged
Conversation
…rief wait - Readable copy (attach hint, footer, placeholder, worked examples, step references, filter counts) moves from --faint to --muted to meet AA in both themes; --faint stays for decoration. - On small screens the brief overlay is a modal dialog: the header and conversation behind it are inert, "/" no longer focuses the hidden composer, and focus returns to the composer once the overlay closes. - On touch and narrow screens every control is at least 40px tall; the footer links grow their hit area without growing the footer. - A "Drafting the brief" status card fills the gap between the reply prose and the finished brief. - Demo replies stop saying "the brief on the right", which is wrong on mobile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the four verified issues from the design review of the minimal redesign (#7):
--faintto--muted. Measured in the browser: footer and attach hint go from 2.34:1 to 4.71:1 in light (dark was 3.70:1), and the placeholder from 2.51:1 to 5.05:1.--faintis now documented as decoration-only.role="dialog",aria-modal). The header and conversation behind it areinert,/no longer focuses the hidden composer, and focus goes back to the composer after Close or Escape. That last step runs in an effect so it fires onceinertis lifted, because focusing an inert element silently fails.(pointer:coarse), (max-width:640px), the header buttons, sample chips, brief tools, evidence filter, feedback buttons and file-remove button are all 40px or taller. Footer links grow their hit area with a pseudo-element, so the footer stays the same size. Desktop with a mouse keeps the compact sizes.Why
Each item was reproduced in the rendered app during the design review: computed contrast ratios, Shift+Tab escaping the overlay to the hidden send button, measured 17–36px targets, and screenshots of the silent wait.
Risk
Low. The changes are CSS plus small UI-state changes in
WorkflowChatandBriefCanvas.useSyncExternalStorereturnsfalseon the server, so the first render is never modal, which matches the old behaviour.inertneeds Safari 15.5+ or Chrome 102+. Copy changes are demo-mode only; the live model prompt already says "canvas".How it was tested
npm run lintexits 0.npm test(tsc, next build, node tests) passes 53/53. That includes a new test pinninginert,aria-modal, the 40px touch block and the move off--faint, plus updated copy assertions.Not verified
🤖 Generated with Claude Code