test(models): cover numeric colon-tagged model selectors - #4189
Open
Yeachan-Heo wants to merge 1 commit into
Open
test(models): cover numeric colon-tagged model selectors#4189Yeachan-Heo wants to merge 1 commit into
Yeachan-Heo wants to merge 1 commit into
Conversation
The #4006 schema change already lets provider/model IDs containing colon tags (e.g. ollama-cloud/deepseek-v4-flash:0731) parse and resolve whole, with only a recognized effort token consumed from the final colon. No tracked test covered the numeric-tag form through the real surfaces, so issue #4187's exact scenario (plus its :xhigh variant) could regress silently. Add regression coverage across schema validation, resolver resolution, profile activation, and custom preset creation, proving a colon-bearing mapping no longer blocks loading or saving other presets. Invalid ambiguous forms remain rejected by the existing red-team cases. Lore-id: 4187 Confidence: high Scope-risk: low Reversibility: revert-commit Tested: model-profiles-schema, model-resolver, model-profile-activation, custom-model-preset-creation, model-profiles-redteam, model-profiles-catalog (220 pass) Not-tested: macOS/Bun 1.3.14 runtime path from the report (covered by the same source under Linux)
Owner
Author
MERGE_READYPR #4189 targets Exact-head CI completed successfully:
The PR is open, mergeable, and clean. No merge or release was performed. — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devalready contains the #4006 schema fix for colon-bearing concrete model IDs. This PR adds exact end-to-end regression coverage for numeric colon tags in model selectors; it contains only four test files and no production source changes.Closes #4187
Verification
packages/coding-agenttypecheck passed—
[repo owner's gaebal-gajae (clawdbot) 🦞]