Repository navigation
feat: add configurable per-task panic handler - #108
Merged
Merged
Conversation
Add WithPanicHandler so callers can supply a custom callback invoked when a task panics inside a worker, replacing the default logger-based reporting. Added: - PanicHandler type func(task Task, recovered any, stack []byte) and the WithPanicHandler config option in config.go - Pool.panicHandler field, initialized from config in NewPool - Pool.handlePanic: delegates to the configured handler, or falls back to the previous "worker exits from panic" log line when none is set, and recovers a panicking handler so the worker goroutine survives Changed: - worker.runTask now reports recovered panics via pool.handlePanic instead of logging directly Tests: - Custom handler: receives the exact panicking task, the recovered value and a non-empty stack; the worker keeps serving subsequent tasks - Panicking handler is recovered and Wait() still returns Docs: - Document WithPanicHandler in the README options table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WithPanicHandler so callers can supply a custom callback invoked when a task panics inside a worker, replacing the default logger-based reporting.
Added:
Changed:
Tests:
Docs: