Repository navigation
fix: make Pool.SetLogger safe during concurrent task execution - #112
Merged
Merged
Conversation
SetLogger wrote the Logger interface field (16 bytes) non-atomically while worker goroutines read it in handlePanic when reporting a recovered task panic. TSan reports this as a data race: Read at ... (*Pool).handlePanic pool.go:718 Previous write at ... (*Pool).SetLogger pool.go:221 Store the logger in an atomic.Pointer[Logger] and read it through getLogger(), which also falls back to the standard-library logger after SetLogger(nil) instead of leaving a nil interface behind. Tests: - TestAgilePoolSetLoggerConcurrentWithTaskPanics reproduces the race under -race against the previous implementation and also pins the visibility contract (the logger installed last receives the next panic report). - TestAgilePoolSetLoggerNilRestoresDefault covers the nil fallback path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetLogger wrote the Logger interface field (16 bytes) non-atomically while worker goroutines read it in handlePanic when reporting a recovered task panic. TSan reports this as a data race:
Read at ... (*Pool).handlePanic pool.go:718
Previous write at ... (*Pool).SetLogger pool.go:221
Store the logger in an atomic.Pointer[Logger] and read it through getLogger(), which also falls back to the standard-library logger after SetLogger(nil) instead of leaving a nil interface behind.
Tests: