Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
web/novnc/patch-novnc.mjs.Vulnerability
V-001web/novnc/patch-novnc.mjs:4Description: The patch-novnc.mjs script accepts a file path via process.argv[2] and directly uses it in fs.readFileSync() and fs.writeFileSync() without any validation. An attacker who can control this argument can read arbitrary files or write to arbitrary locations on the filesystem using path traversal sequences like '../../../etc/passwd'.
Evidence
Exploitation scenario: An attacker who can invoke the script with controlled arguments executes: node web/novnc/patch-novnc.mjs '../../../etc/passwd' to read sensitive system files, or node web/novnc/patch-novnc.mjs.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
web/novnc/patch-novnc.mjsBehavior Preservation
The change is scoped to 1 file on the vulnerable path.
Automated security fix by OrbisAI Security