Skip to content

Fix adaptive translation review feedback - #4

Merged
Yipxiyi merged 1 commit into
mainfrom
agent/fix-adaptive-review-feedback
Jul 24, 2026
Merged

Yipxiyi merged 1 commit into
mainfrom
agent/fix-adaptive-review-feedback

Conversation

@Yipxiyi

@Yipxiyi Yipxiyi commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • validate repaired provider output inside the recursive safety fallback so incomplete or structurally invalid multi-row responses split into smaller requests
  • treat persisted jobs without adaptive metadata as legacy custom jobs and preserve their manual concurrency, timeout, and retry settings
  • preserve exact text-node whitespace when oversized leaf blocks are split and merged
  • add missing v0.9.0 adaptive-processing notes and document these fixes under Unreleased
  • add regression coverage for all three code paths

Root cause

The original adaptive reliability change validated provider rows only after returning from the recursive fallback, defaulted missing adaptive plan metadata to enabled, and normalized split output through element_text(). Those paths respectively bypassed splitting, overrode legacy settings, and collapsed significant whitespace.

Validation

  • PYTHONPATH=src:tests python3 -m unittest discover -s tests -v — 84 passed
  • python3 -m py_compile src/babel_epub/*.py
  • npm test --prefix web — 8 passed
  • npm run build --prefix web
  • git diff --check

Follow-up to the unresolved review feedback on #3.

@Yipxiyi
Yipxiyi marked this pull request as ready for review July 24, 2026 10:55
@Yipxiyi
Yipxiyi merged commit 632fcce into main Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant