Repository navigation
docs: align README with Render setup and replace Fly mentions - #42
Merged
Merged
Conversation
Owner
|
Thanks a lot @obithelight, this is a clean first PR and exactly the scope the issue asked for.
I've approved the CI run and will merge once the tests pass 🙌 — Max |
Owner
|
Merged 🎉 Congrats on your first contribution to OpenToAll, @obithelight, and thanks for the careful cross-checking with — Max |
Contributor
Author
|
Thank you @Ymax27 for the quick review and clear answers. I learned a lot from this. I'll look at the other good first issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
Replaced every mention of Fly in
README.mdwith the Render + Neon setup:variables, OAuth callback, the two crons, pointer to
render.yaml)Written in French to match the rest of the README, as requested.
Why
Closes #3
Production runs on Render (
opentoall.onrender.com), but the README stillpointed new contributors to Fly.
How I checked
render.yamlandentrypoint.sh.CONTRIBUTING.md, so its label links are unchanged.Questions
https://opentoall.onrender.comas the Homepage URL. Is that correct?fly deployandfly.tomland did not add a Render equivalent,because the issue says not to invent steps. The deploy section points to
render.yamlinstead.USE_REDIS_CACHE=0was in the old Fly secrets list but is not inrender.yaml, so I left it out. Is this okay as per requirements orshould it still be documented?