Repository navigation
fix: improve image alt text across templates - #56
Conversation
Ymax27
left a comment
There was a problem hiding this comment.
Thanks a lot for jumping on this so quickly, and welcome to OpenToAll! 🎉
The logo change is spot on: the site name is right next to it, so alt="" avoids a double read-out.
Two small things before we merge:
- Leaderboard avatars: the username is already displayed right next to each avatar inside the same link, so
alt="{{ username }}"makes screen readers announce it twice. The originalalt=""was actually correct there, could you revert those two lines? - Scope: #48 asks to check the homepage and the Explore cards at minimum. Could you take a look at the images there (and add a meaningful alt where an image carries information)? If there's nothing to change, just say so in the PR description.
I've approved the CI run so you'll see the test results. Thanks again!
— Max
|
Thanks for the review, Max! I've pushed the changes:
Could you re-approve the CI run when you get a chance? Thanks! |
|
Merged! 🎉 Thank you so much @sssimransingh26-bit. You handled the feedback quickly, went beyond the issue with a careful audit of every Welcome aboard, and looking forward to your skeleton PR for #27! 🚀 — Max |
Summary
alt=""), since the site name is already visible on the page.sr-only sm:not-sr-onlyinstead ofhidden sm:inline), so those links have an accessible name.Scope check (#48)
home.htmlhas no<img>of its own, and the repo avatars in_issue_card.htmlalready usealt=""becauseowner/repois shown next to them. No further changes needed.Testing
<img>; every image now has an empty alt, and each one has its name or label visible next to it.Closes #48