Skip to content

feat: add loading skeleton for issue cards during HTMX requests - #58

Merged
Ymax27 merged 1 commit into
Ymax27:mainfrom
sssimransingh26-bit:feat/loading-skeleton
Oct 21, 2026
Merged

Ymax27 merged 1 commit into
Ymax27:mainfrom
sssimransingh26-bit:feat/loading-skeleton

Conversation

@sssimransingh26-bit

Copy link
Copy Markdown
Contributor

Summary
Add CSS-only skeleton placeholders on the Explore page, shown while HTMX loads filtered results or another page.
Skeletons use the same grid as the real cards, so there is no layout jump when results arrive.
prefers-reduced-motion users see static placeholders (no shimmer).
The skeleton container is aria-hidden; the existing #list-status live region still announces loading to screen readers.
Implementation note

The issue suggested hx-on handlers to dim #issue-list. Instead I hide the list with a CSS rule (body:has(#skeleton-loader.htmx-request) #issue-list) while the skeleton is visible, so no JavaScript is needed. Happy to switch to the opacity approach if you prefer.

Testing
pytest: 28 passed.
Tested filter changes and pagination with Slow 3G throttling.

Closes #27

@Ymax27 Ymax27 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, JS-free and accessible. Matching the real card grid and covering pagination is a great touch. ✅

— Max

@Ymax27
Ymax27 merged commit fe023ee into Ymax27:main Oct 21, 2026
1 check passed
@Ymax27

Ymax27 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Merged! 🎉 Thank you again @sssimransingh26-bit. Two solid PRs in two days! The CSS-only approach with :has() is elegant, and testing on Slow 3G is exactly the mindset OpenToAll is built around (real-world connections). The Explore page feels much smoother now.

If you're up for more, feel free to grab any open good first issue. You're always welcome here! 🚀

And if you enjoyed contributing, a ⭐ on the repo helps more developers discover OpenToAll!

— Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add loading skeleton for issue cards during HTMX requests

2 participants