Repository navigation
feat: add loading skeleton for issue cards during HTMX requests - #58
Merged
Merged
Conversation
Owner
|
Merged! 🎉 Thank you again @sssimransingh26-bit. Two solid PRs in two days! The CSS-only approach with If you're up for more, feel free to grab any open And if you enjoyed contributing, a ⭐ on the repo helps more developers discover OpenToAll! — Max |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CSS-only skeleton placeholders on the Explore page, shown while HTMX loads filtered results or another page.
Skeletons use the same grid as the real cards, so there is no layout jump when results arrive.
prefers-reduced-motion users see static placeholders (no shimmer).
The skeleton container is aria-hidden; the existing #list-status live region still announces loading to screen readers.
Implementation note
The issue suggested hx-on handlers to dim #issue-list. Instead I hide the list with a CSS rule (body:has(#skeleton-loader.htmx-request) #issue-list) while the skeleton is visible, so no JavaScript is needed. Happy to switch to the opacity approach if you prefer.
Testing
pytest: 28 passed.
Tested filter changes and pagination with Slow 3G throttling.
Closes #27