Skip to content

fix: make select dropdown options readable in dark mode - #60

Merged
Ymax27 merged 1 commit into
Ymax27:mainfrom
sssimransingh26-bit:fix/dark-mode-select-options
Oct 26, 2026
Merged

Ymax27 merged 1 commit into
Ymax27:mainfrom
sssimransingh26-bit:fix/dark-mode-select-options

Conversation

@sssimransingh26-bit

Copy link
Copy Markdown
Contributor

Summary

  • Set color-scheme for the light and dark themes so native <select> option lists follow the theme.
  • Add explicit background and text colors for select option as a fallback.

Testing

  • Checked all 4 selects (3 on Explore, 1 on Leaderboard) in light and dark mode in Chrome.
  • pytest: 28 passed.

Closes #39

@Ymax27 Ymax27 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the fix the issue described, minimal and theme-aware. Thanks for checking all four selects in both modes! ✅

— Max

@Ymax27
Ymax27 merged commit e9ff9ca into Ymax27:main Oct 26, 2026
1 check passed
@Ymax27

Ymax27 commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Merged! 🎉 Thank you @sssimransingh26-bit, that's your third merged PR in a week. Dark-mode dropdowns are now readable for everyone, and the minimal color-scheme approach keeps the CSS tidy. Checking all four selects in both themes is the kind of thoroughness we love.

I looked forward to see your futures contributions

— Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode: sort/filter dropdown options are unreadable

2 participants