Add timeout and process cleanup to igor.exe invocations - #327
Merged
sihammill merged 2 commits intoJul 14, 2026
Merged
Conversation
- Igor.exe can get stuck endlessly retrying a runtime download (e.g. network/CDN issue), and `run_and_capture` had no timeout — it would hang until the outer CI job's `timeout-minutes` killed things, at which point the orphaned igor.exe process wasn't cleaned up (leaving a `Terminate batch job (Y/N)?` prompt on the runner). - `run_and_capture` now accepts an optional `timeout`. On timeout, or if the task is cancelled (e.g. the CI job timeout firing), it kills the igor.exe process tree via the existing `kill_process_tree` helper and raises a clear `TimeoutError` instead of hanging silently. - Wired a 5-minute `IGOR_TIMEOUT_SECONDS` cap into the three igor.exe calls (`igor_get_license`, `igor_get_runtime_version`, `igor_install_runtime`) that were vulnerable to this hang.
ksuchitra532
approved these changes
Jul 14, 2026
sihammill
deleted the
Add-timeout-and-process-cleanup-to-igor.exe-invocations
branch
July 14, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_and_capturehad no timeout — it would hang until the outer CI job'stimeout-minuteskilled things, at which point the orphaned igor.exe process wasn't cleaned up (leaving aTerminate batch job (Y/N)?prompt on the runner).run_and_capturenow accepts an optionaltimeout. On timeout, or if the task is cancelled (e.g. the CI job timeout firing), it kills the igor.exe process tree via the existingkill_process_treehelper and raises a clearTimeoutErrorinstead of hanging silently.IGOR_TIMEOUT_SECONDScap into the three igor.exe calls (igor_get_license,igor_get_runtime_version,igor_install_runtime) that were vulnerable to this hang.