First pass at getting data for XML sitemaps from indexables#17580
Closed
jdevalk wants to merge 27 commits into
Closed
First pass at getting data for XML sitemaps from indexables#17580jdevalk wants to merge 27 commits into
jdevalk wants to merge 27 commits into
Conversation
9 tasks
added 23 commits
October 31, 2021 23:05
…itemaps-indexables
diedexx
reviewed
Dec 14, 2021
| } | ||
|
|
||
| foreach ( $user_pages as $users_page ) { | ||
| array_shift( $users_page ); |
Member
There was a problem hiding this comment.
@jdevalk this line should be removed, right? It makes it that the second most recent last modified date is shown for each page instead of the most recent. Or is there something I'm missing?
…dv/xml-sitemaps-indexables
7 tasks
Member
|
Replaced with #17869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
wpseo_sitemap_exclude_empty_termsandwpseo_sitemap_exclude_empty_terms_taxonomyfilters. To remove terms from the XML sitemap, make sure they're set tonoindexin Indexables.wpseo_hit_sitemap_indexaction.wpseo_sitemap_entryfilter has theobject_id, so the WordPress ID for the object, as its third parameter now.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Quality assurance
Fixes #