Restore RC tag triggers in deploy.yml — RC builds belong in Yoast-dist#295
Merged
Conversation
PR #283 added `'!*-RC*'` / `'!*-rc*'` to the tag-trigger list under the mistaken assumption that the dist repo's main branch should only carry final releases. Looking at the dist history, every prior RC (1.18-RC1 through 1.18-RC7) was already published there as a "Release x.y-RCn" commit on main — the dist repo is the install target for internal consumers and is meant to carry RC builds alongside final releases. The exclusion silently skipped Deploy for 1.19-RC2/RC3/RC4 (the RC1 tag slipped through because it points at a commit predating the filter), so Yoast-dist is now stale for those iterations. Remove the filter; from the next RC tag push onwards, Deploy will fire and publish to `Yoast-dist@main` as before. Backfilling RC2/RC3/RC4 in the dist repo would require re-pushing those tags (or triggering Deploy manually with the right ref), which is a separate one-time chore — out of scope for this revert.
enricobattocchi
force-pushed
the
fix-deploy-rc-tags
branch
from
8201169 to
b90d8ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
PR #283 added
'!*-RC*'/'!*-rc*'todeploy.yml's tag-trigger list under the mistaken assumption that the dist repo's main branch should only carry final releases. The dist repo history shows that's not the convention — every prior RC (1.18-RC1through1.18-RC7) was already published there as a "Release x.y-RCn" commit on main, alongside the final "Release 1.18".Result of the bad filter: Deploy silently skipped
1.19-RC2,1.19-RC3, and1.19-RC4tag pushes. (1.19-RC1slipped through and did deploy, because it points atcdb5d0b— a commit predating the filter merge.)Remove the filter. From the next RC tag push onwards, Deploy will fire and publish to
Yoast-dist@mainlike it used to.Targeting
developrather thanrelease/1.19because there will be no further 1.19 RC; the fix is forward-looking and will be exercised by the next plugin release cycle's RC1.State of
Yoast-distYoast-distcurrently hasRelease 1.19-RC1,Release 1.19,Release 1.18, … Missing:Release 1.19-RC2/RC3/RC4. Not backfilling — the gap is invisible to consumers going forward.Milestone
Test instructions
Test instructions for the acceptance test before the PR gets merged
There's no in-flight RC for this to be validated against — coverage available now:
deploy.ymldiff and confirm the'!*-RC*'/'!*-rc*'exclusions are removed from the tag-trigger list.actionlint/ CI passes (workflow file still parses).First real-world validation happens on the next plugin release cycle's RC1 — its tag push should trigger Deploy and produce a
Release <next>-RC1commit onYoast-dist/yoast-test-helper@main.Test instructions for QA when the code is in the RC
Fixes #