Attach macOS .dmg to GitHub Releases + refresh CLAUDE.md - #2
Merged
Conversation
…nia port Adds a "Code signing" section recording the chosen approach (SignPath.io OSS), the three-part status (Part 1 in-repo done, Parts 2-3 waiting on SignPath application), and the deliberate exclusion of macOS from the signing scope. Also refreshes stale WPF-era references throughout: entry points, solution layout, gotchas, and adds the macOS build section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds a build-dmg job to release.yml (macos-latest, mirrors the Windows installer job's shape) that runs build-macos.sh against the bumped Directory.Build.props, produces the universal .dmg, and hands it off to the publish job for inclusion in the GitHub Release alongside the .exe installers. v3.4.0 released without the DMG because the macos job was only wired into build.yml (PR CI), not release.yml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-latestjob was only wired intobuild.yml(PR CI), notrelease.yml. This adds abuild-dmgjob to the release workflow and attaches the DMG to the GitHub Release.Test plan
release.ymlYAML parses cleanly (3 targeted edits: newbuild-dmgjob, new download-artifact step inpublish,.dmgglob in releasefiles)..exeinstallers and a universal.dmg.Notes
build-dmgjob consumes thebumped-propsartifact the same waybuild-installerdoes, so the DMG's version in-bundle (Info.plist, assembly, filename) tracks the release version.publishnow depends onbuild-dmg— if the DMG build fails, the release is blocked. That's the right trade-off: a release without the DMG is what prompted this PR.🤖 Generated with Claude Code