Fix: mark build-macos.sh executable (unblocks release DMG job) - #3
Merged
Conversation
The macOS release job failed with "Permission denied" on ./build-macos.sh because the file was committed from Windows bash, where chmod +x does not propagate into git's mode bits (stays at 100644). Setting 100755 so macos-latest runners can execute it directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ImageResize.ContextMenu/nuget.config had a Local source pointing at ../nupkgs. ContextMenu references Core via ProjectReference (never PackageReference), so the Local feed isn't used by the restore — but NuGet still errors with NU1301 at restore time when the directory is missing, which is always the case on a fresh CI checkout. Was breaking both the build.yml ContextMenu (windows + macos) jobs. Also drops the now-redundant "Restore nupkgs" step in release.yml's Windows installer job — it was only there to paper over the same NU1301. The nupkgs artifact is still uploaded by build-library and downloaded by publish for nuget.org push + GitHub Release asset. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build ContextMenu DMG (macos)job failed withPermission deniedon./build-macos.sh(run 24605081151).chmod +xdoes not propagate into git's mode bits, so it stayed at100644.git update-index --chmod=+x build-macos.sh— now100755, executable on macOS / Linux runners.Test plan
git ls-files --stage build-macos.sh→100755locally.Impact on v3.4.0 release
v3.4.0 did publish the .nupkg and the Windows
.exeinstallers — thepublishjob only depends on all three builds succeeding, and sincebuild-dmgfailed, thepublishjob was skipped. So:🤖 Generated with Claude Code