Develop - #84
Merged
Merged
Conversation
Remove admin-only backoffice API endpoints and UI configuration walkthroughs from documentation. Refocus content on what developers building sites actually need: storefront APIs, code examples, and practical integration guidance. - products: Remove admin import/export API, backoffice filter CRUD, feed management endpoints - checkout: Remove internal caching mechanics, cookie validation internals, strategy interfaces - shopping: Consolidate confusing method variants, remove internal calculation details - discounts: Replace admin config reference with checkout API usage and display patterns - upsells: Replace admin rule config with storefront API endpoints and Razor examples - payments: Remove payment link admin API, keep invoice reminder notification handlers - tax: Remove backoffice activation endpoints, keep custom provider implementation guide - shipping: Remove admin UI config, keep carrier setup and custom provider creation - fulfilment: Remove setup wizard steps, keep integration mechanics and webhook processing - orders: Replace UI workflow framing with EditInvoice API contract - customers: Reduce admin-heavy content to storefront-relevant auto-creation and lookup - store-config: Focus settings on storefront-affecting values, minimize suppliers/warehouses - api: Replace 560-line endpoint dump with overview pointing to Swagger UI - backoffice: Replace internal UI architecture with site-builder orientation guide - background-jobs: Remove implementation patterns, keep job inventory and configuration Net reduction of ~2,000 lines across 25 files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f63d372aa0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| new RemovedAutoAddRecord { ProductId = productId }, | ||
| ct); | ||
| ``` | ||
| Resets the session to its default state. This is called automatically after order completion. |
There was a problem hiding this comment.
This line states that ClearSessionAsync is called automatically after order completion, but in the current code there are no production call sites for ICheckoutSessionService.ClearSessionAsync (only the service implementation and tests reference it). That makes the guidance inaccurate for integrators: if they rely on this statement, stale checkout session data can persist unless they clear it explicitly.
Useful? React with 👍 / 👎.
- Microsoft.EntityFrameworkCore.* 10.0.2 → 10.0.4 - Microsoft.AspNetCore.* 10.0.2 → 10.0.4 - Microsoft.Extensions.* 10.0.2 → 10.0.4 - Umbraco.Cms 17.2.1 → 17.3.0 - Stripe.net 50.4.0 → 51.0.0 - Avalara.AvaTax 26.2.0 → 26.3.2 - FluentFTP 53.0.2 → 54.1.0 - Humanizer 3.0.8 → 3.0.10 - StructuredFieldValues 0.7.6 → 0.7.7 - coverlet.collector 8.0.0 → 8.0.1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ClearSessionAsync is not called automatically after order completion — integrators must call it explicitly. Updated docs to reflect this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.