Develop - #88
Conversation
The publish workflow picked up old v0.1.* tags when bumping patch, causing stable releases to appear as 0.1.60, 0.1.61 instead of 1.0.0. Tighten both the HEAD-tag reuse check and the latest-stable lookup to require major >= 1, so the fallback correctly starts the new line at 1.0.0 and subsequent pushes increment as 1.0.1, 1.0.2, etc. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace relative ../../src/... links with https://github.com/YodasMyDad/Merchello/blob/main/src/... across all documentation pages so source-code references resolve correctly when the docs are rendered on GitHub Pages (relative paths break out of the mkdocs site root). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9068289d3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # Find the latest stable (non-prerelease) tag anywhere in history. | ||
| latest="$(git tag -l 'v[0-9]*.[0-9]*.[0-9]*' | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1 || true)" | ||
| latest="$(git tag -l 'v[1-9]*' | grep -E '^v[1-9][0-9]*\.[0-9]+\.[0-9]+$' | sort -V | tail -n 1 || true)" |
There was a problem hiding this comment.
Preserve v0 tags when deriving next release version
This filter now excludes all v0.x.y tags, so repositories that are still on 0-major releases will be treated as if no stable tag exists and the workflow will jump to v1.0.0 on the next publish run. In that scenario, reruns also lose the intended idempotent behavior for existing 0-major tags. If 0-major history must remain part of version progression, keep v0 in the stable-tag match (or add an explicit migration step before switching to the stricter pattern).
Useful? React with 👍 / 👎.
No description provided.