Skip to content

Add new message format for penalty served messages #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yoghurt1 merged 1 commit into from
May 24, 2026
Merged

Add new message format for penalty served messages #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/services/message/messageMapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ export class MessageMapper {
return Emote.NO_FURTHER_ACTION
}

if (message.message.includes('PENALTY SERVED')) {
return Emote.NO_FURTHER_ACTION
}

if (message.message.includes('PENALTY')) {
return Emote.BLACK
}
Expand Down Expand Up @@ -86,6 +90,10 @@ export class MessageMapper {
return FlagColour.YELLOW
}

if (message.message.includes('PENALTY SERVED')) {
return FlagColour.GREEN
}

if (message.message.includes('PENALTY')) {
return FlagColour.BLACK
}
Expand Down
12 changes: 11 additions & 1 deletion tests/unit/services/message/messageMapperTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ describe('MessageMapper', () => {
{ message: 'NOTED', emote: Emote.NOTED },
{ message: 'NO FURTHER ACTION', emote: Emote.NO_FURTHER_ACTION },
{ message: 'PENALTY', emote: Emote.BLACK },
{ message: 'TRACK LIMITS', emote: Emote.OFF_TRACK }
{ message: 'TRACK LIMITS', emote: Emote.OFF_TRACK },
{ message: 'PENALTY SERVED', emote: Emote.NO_FURTHER_ACTION }
]

for (const testCase of cases) {
Expand Down Expand Up @@ -174,6 +175,15 @@ describe('MessageMapper', () => {
assert.equal(embed.data.color, FlagColour.YELLOW)
})

it('should use green colour when message contains PENALTY SERVED', () => {
message = generateEnrichedRaceControlMessage(undefined, 'PENALTY SERVED')
message.flag = undefined

const embed: EmbedBuilder = mapper.mapRaceControlMessage(message)

assert.equal(embed.data.color, FlagColour.GREEN)
})

it('should use black colour when message contains PENALTY', () => {
message = generateEnrichedRaceControlMessage(undefined, 'PENALTY')
message.flag = undefined
Expand Down
Loading