Skip to content

Fix colour for NFA messages #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yoghurt1 merged 1 commit into from
Jun 7, 2026
Merged

Fix colour for NFA messages #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/services/message/messageMapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ export class MessageMapper {
return FlagColour.YELLOW
}

if (message.message.includes('NO FURTHER ACTION')) {
return FlagColour.GREEN
}

if (message.message.includes('PENALTY SERVED')) {
return FlagColour.GREEN
}
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/services/message/messageMapperTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,15 @@ describe('MessageMapper', () => {
assert.equal(embed.data.color, FlagColour.YELLOW)
})

it('should use green colour when message contains NO FURTHER ACTION', () => {
message = generateEnrichedRaceControlMessage(undefined, 'NO FURTHER ACTION')
message.flag = undefined

const embed: EmbedBuilder = mapper.mapRaceControlMessage(message)

assert.equal(embed.data.color, FlagColour.GREEN)
})

it('should use green colour when message contains PENALTY SERVED', () => {
message = generateEnrichedRaceControlMessage(undefined, 'PENALTY SERVED')
message.flag = undefined
Expand Down
Loading