Skip to content

画像生成の二重応答と古いinteractionへの編集を修正 - #134

Open
YoneRai12 wants to merge 8 commits into
codex/ci-dependency-diff-20261002-r1from
codex/fix-double-defer-in-auto-style-generation
Open

YoneRai12 wants to merge 8 commits into
codex/ci-dependency-diff-20261002-r1from
codex/fix-double-defer-in-auto-style-generation

Conversation

@YoneRai12

@YoneRai12 YoneRai12 commented Apr 8, 2026 •

Copy link
Copy Markdown
Owner

Auto styleのbutton callbackで既にdeferしたinteractionを再びdeferすると、InteractionRespondedで画像生成が止まります。また、生成中の表示更新が古いoriginal_interactionを参照していました。

応答済みならdeferを追加せず、Auto styleと共通生成の表示更新を、その操作で渡された現在のinteractionへ統一します。古いinteractionへの編集が必ず失敗するfixtureを使い、Auto styleと通常styleの実button callbackを通る2件の回帰試験を追加しました。同じ2件を既存core-test jobで実行します。

前提PRは #610(Core CIの依存解決と差分検査) です。CI基盤を別branchに分離し、このPRはそのbranchをbaseとする4ファイルの画像生成差分です。#610の統合後にbaseをmainへ戻して最終確認します。

検証:

  • 修正前に2件の失敗を確認し、修正後は2 passed。deferは各操作で1回、編集先は現在のinteraction。
  • repository rootとCI相当のcore作業directoryから同じ2件が成功。
  • ruff、compile、YAML parse、diff check、秘密・公開path・Unicode検査成功。
  • GitHubのこのheadのrequired checksとreview intakeは別に確認。

実Discord接続による受入は行っていません。

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check to prevent double-deferring interactions in the start_generation method. The reviewer suggests refactoring the method to consistently use the passed interaction object instead of self.original_interaction to avoid potential expiration errors and improve maintainability.

Comment thread src/views/image_gen.py
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T02:26:12.942075Z 7d3f152 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50e69610e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci_quality_scans.py
Comment thread core/requirements.txt
@YoneRai12 YoneRai12 changed the title fix(image_gen): prevent double interaction defer in auto image style generation 画像生成の二重応答と古いinteractionへの編集を修正 Oct 2, 2026
@YoneRai12
YoneRai12 changed the base branch from main to codex/ci-dependency-diff-20261002-r1 October 2, 2026 02:24
@YoneRai12 YoneRai12 added the intake-reviewed Maintainer confirmed PR/review/comment intake for current head. label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex intake-reviewed Maintainer confirmed PR/review/comment intake for current head.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant