Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a check to prevent double-deferring interactions in the start_generation method. The reviewer suggests refactoring the method to consistently use the passed interaction object instead of self.original_interaction to avoid potential expiration errors and improve maintainability.
…r-in-auto-style-generation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50e69610e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Auto styleのbutton callbackで既にdeferしたinteractionを再びdeferすると、
InteractionRespondedで画像生成が止まります。また、生成中の表示更新が古いoriginal_interactionを参照していました。応答済みならdeferを追加せず、Auto styleと共通生成の表示更新を、その操作で渡された現在のinteractionへ統一します。古いinteractionへの編集が必ず失敗するfixtureを使い、Auto styleと通常styleの実button callbackを通る2件の回帰試験を追加しました。同じ2件を既存core-test jobで実行します。
前提PRは #610(Core CIの依存解決と差分検査) です。CI基盤を別branchに分離し、このPRはそのbranchをbaseとする4ファイルの画像生成差分です。#610の統合後にbaseをmainへ戻して最終確認します。
検証:
実Discord接続による受入は行っていません。