Repository navigation
Added eslint and fixed issues that were caught. - #39
Merged
Merged
Conversation
|
@Zwee42 is attempting to deploy a commit to the Yoseph's projects Team on Vercel. A member of the Team first needs to authorize it. |
Rebased onto the new main (tour, root/sinus, docs commits) and resolved the Engine.ts merge conflict (kept both the new onHover handler and the void-wrapped onClick). The tour feature's code added 15 errors and 1 warning under the eslint setup; fixed: - tour.ts: wrap AbortSignal.reason in an Error for promise rejects - tour.test.ts: type the .catch(error) param as unknown - tourTargets.test.ts: type-only import for the mocked module, Manifest cast for the JSON.parse registry build - Engine.test.ts: type the entries map, drop unneeded async - GuidedTour.tsx: reset tour state via render-time adjustment instead of setState in an effect; read readiness through the store accessor so the exhaustive-deps rule is satisfied without restarting the tour; drop redundant non-null assertions after the early return; wrap startGuide handlers - SearchPanel.tsx / TopBar.tsx: wrap detached store methods Verified: lint 0 errors/warnings, typecheck, tsc6, 211 tests, build, and headless browser tour check (auto-start, pause/resume, advance, skip, replay resets to step 1, no console errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the repository's first typed ESLint setup and enforce code quality in CI. React hook mistakes in both
.tsand.tsxfiles now fail the lint check, including missing effect dependencies. JSX accessibility rules remain scoped to.tsx.Evidence
.tshook mistakes were unchecked; a missing.tsxeffect dependency produced zero errors and one warning. The initial expanded tree had 20 Tab stops.After: Missing dependencies and conditional hooks fail regression tests in both extensions. Browser verification confirms one Tab stop, parent/child navigation, Home/End, Tab exit, selection reveal, and the visible focus ring, without console errors.
npm run lint, both typechecks, all 218 tests (also withCI=true), andnpm run buildpass.cffe9b6, including both typechecks, lint, 218 tests, and build.Merge Danger
Door: two-way; the change can be reverted.
Blast Radius: tooling and tree keyboard interaction. CI is stricter, and keyboard users traverse the tree using arrows instead of tabbing through every row.
Closes #42.