Skip to content

Improve explorer layout, navigation and loading recovery - #45

Merged
Yoosseph merged 3 commits into
mainfrom
codex/explorer-ui-reliability
Oct 10, 2026
Merged

Yoosseph merged 3 commits into
mainfrom
codex/explorer-ui-reliability

Conversation

@Yoosseph

@Yoosseph Yoosseph commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

At 1280×720, expanded layer controls could leave no space for the layer list. Tooth selections also replaced the previous URL, and failed tooth downloads could not be retried. The guide could remain at step 1 after a background tab became visible, and its card could jump between sides during a step. This restores reachable layers, browser history, loading recovery, and reliable guide playback across desktop and phone.

 user chooses anatomy
- update scene → replace previous URL → load details
+ load details (retryable, latest request wins) → commit scene → push one URL

The phone detail tray keeps its actions visible while text scrolls and expands for reading. Search uses a native dialog with contained keyboard focus, Escape/backdrop dismissal, and focus restoration. Layer counts distinguish teeth from mesh parts; primary dentition opens its development view explicitly. Nerve controls and canal study data can collapse.

Shared scene resets and panel-inset measurement now have dedicated modules. Browser regression tests run in CI alongside the existing type, lint, unit, content-coverage, and build checks.

Guide playback reads the current document visibility instead of a stale mount-time value. Its card chooses a side when pointing to a new step and adapts on window resize; pointer tracking continues as controls move.

Closes #44.

Evidence

Before: desktop layers had no usable list After: layers remain reachable
Before After
Phone: pinned actions Phone: expanded reading tray
Phone details Expanded details
  • Before: browser testing caught a retry button whose clicks passed through to the canvas.
    After: error cards accept pointer input; the browser test aborts a tooth download and verifies Retry restores it without a reload.
  • Validation: 233 unit tests pass; app/test type checks, lint and production build pass.
  • Browser regression suite: 12 checks pass across desktop and phone; 2 viewport-specific cases intentionally skip on the other viewport.
Before: guide remains at step 1 while playing After: complete guide reaches step 17
Stalled guide Completed guide
  • Added guide regressions: both the visibility stall and side-switching tests failed before the fix. Afterward, 5 guide checks pass across desktop and phone, with 1 desktop-only placement check skipped on phone. Complete playback, dismissal, focus restoration, clean URL, and replay are covered.
  • Rechecked after the guide fixes: all 233 unit tests, app/test type checks, lint, and production build pass. Manually watched the complete desktop guide finish at 17 / 17.

Merge Danger

Door: two-way

Can be reverted without a data migration.

Blast Radius: Explorer

Changes shared panel layout, scene transition resets, asynchronous selection/history behavior, and guide playback/placement. Desktop and phone regressions cover navigation, search focus, layer access, primary dentition, pinned actions, loading retry, credits deep links, and guide completion/replay. CI allows four minutes per test for software-rendered 3D scenes. Phone layout checks use a 1× pixel density with touch/mobile emulation. Other browser engines are not covered by the new Chromium suite.

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dental-scope Ready Ready Preview Oct 10, 2026 2:48am UTC

@Yoosseph
Yoosseph merged commit 712f329 into main Oct 10, 2026
3 checks passed
@Yoosseph
Yoosseph deleted the codex/explorer-ui-reliability branch October 10, 2026 15:12

This branch was successfully deployed

1 active deployment
Preview — 712f329c Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve explorer layout, navigation, accessibility and loading reliability

1 participant