Skip to content

fix(): Fix Undefined Crash #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arielpetit wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −135
Open

fix(): Fix Undefined Crash #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/scoring/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,11 @@ export function buildCard(s: Signals): Card {
// `finish` directly rather than via pickFinish: any overall >= 90 would
// otherwise auto-promote to ICON (and flip club/archetype), hijacking the look.
const founder = FOUNDERS[s.login.toLowerCase()];
const overall = founder
? FOUNDER_OVERALL[s.login.toLowerCase()]
: clamp(baseOVR + Math.round(K.legacy.bonusMax * L), 1, 99);
const founderOverall = founder ? FOUNDER_OVERALL[s.login.toLowerCase()] : undefined;
const overall =
founderOverall !== undefined
? clamp(founderOverall, 1, 99)
: clamp(baseOVR + Math.round(K.legacy.bonusMax * L), 1, 99);
const finish: Finish = founder ? "founder" : pickFinish(overall, L, s.recent_spike, s.login);
const archetype = founder
? { name: "Founder", blurb: "co-founder of GitFut — they built the very scout reading this card" }
Expand Down
Loading