50 suggested profiles by YoungMame · Pull Request #51 · YoungMame/matcha

YoungMame · 2025-11-25T06:17:34Z

No description provided.

Copilot

Pull request overview

This PR implements a user browsing feature with filtering and sorting capabilities, allowing users to discover compatible profiles based on various criteria including location, age, tags, and fame rating.

Adds a new BrowsingService with configurable filters (age, location, fame rate, tags) and sorting options (distance, age, fame rate, tags, or a weighted default algorithm)
Implements HTTP endpoints for browsing users with URL-based parameter passing
Updates the quickUser test fixture to use 'bisexual' orientation for better test coverage with the new browsing logic

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 52 comments.

Show a summary per file

File	Description
`fastify/assets/test/integration/ws/browsing.test.ts`	New integration tests for basic browsing functionality and match scoring
`fastify/assets/test/integration/ws/browsing.filtersort.test.ts`	Comprehensive tests for filtering and sorting capabilities
`fastify/assets/test/integration/utils/browsing.ts`	Test utilities for setting user profile attributes and calculating age differences
`fastify/assets/test/integration/fixtures/auth.fixtures.ts`	Changed default orientation from 'heterosexual' to 'bisexual'
`fastify/assets/srcs/services/BrowsingService.ts`	Core service implementing browsing logic with SQL queries and sorting algorithms
`fastify/assets/srcs/routes/private/user/me/profile.ts`	Removed required constraint on location latitude/longitude fields
`fastify/assets/srcs/routes/private/index.ts`	Registered browsing routes under `/browsing` prefix
`fastify/assets/srcs/routes/private/browsing/index.ts`	Defined browsing endpoint with route schema validation
`fastify/assets/srcs/controllers/private/me/profile.ts`	Refactored profile update handler with explicit type checking
`fastify/assets/srcs/controllers/private/browsing/index.ts`	Handler for processing browsing requests and returning filtered/sorted users
`fastify/assets/srcs/app.ts`	Registered BrowsingService plugin
`fastify/assets/@types/fastify.d.ts`	Added type declarations for browsingService

Comments suppressed due to low confidence (2)

fastify/assets/test/integration/ws/browsing.test.ts:10

Unused imports getAgeDifference, likeUser, viewUser.

import { setTags, setLocalisation, setBirthDate, likeUser, viewUser, getAgeDifference } from '../utils/browsing';

fastify/assets/test/integration/ws/browsing.test.ts:14

Unused import create.

import { create } from 'node:domain';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-25T06:28:21Z

+
+        const rows = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { tags: ['music'] });
+
+        for (let i = 0; i < rows.length - 1; i++) {


Off-by-one error in test: The loop condition i < rows.length - 1 means the last element in the array is never tested. This should be i < rows.length to ensure all users match the 'music' tag filter.

Suggested change

for (let i = 0; i < rows.length - 1; i++) {

for (let i = 0; i < rows.length; i++) {

Copilot · 2025-11-25T06:28:21Z

+        for (let i = 0; i < rows.length - 1; i++) {
+            expect(rows[i].fameRate).to.be.at.least(300);
+            expect(rows[i].fameRate).to.be.at.most(800);
+        }
+
+        const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });
+        for (let i = 0; i < rows1.length - 1; i++) {
+            expect(rows1[i].fameRate).to.be.at.least(600);
+            expect(rows1[i].fameRate).to.be.at.most(1000);
+        }
+
+        const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });
+        for (let i = 0; i < rows2.length - 1; i++) {


Off-by-one error in test: The loop condition i < rows1.length - 1 means the last element in the array is never tested for the fame rate filter. This should be i < rows1.length to ensure all users match the fame rate range.

Suggested change

for (let i = 0; i < rows.length - 1; i++) {

expect(rows[i].fameRate).to.be.at.least(300);

expect(rows[i].fameRate).to.be.at.most(800);

}

const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });

for (let i = 0; i < rows1.length - 1; i++) {

expect(rows1[i].fameRate).to.be.at.least(600);

expect(rows1[i].fameRate).to.be.at.most(1000);

}

const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });

for (let i = 0; i < rows2.length - 1; i++) {

for (let i = 0; i < rows.length; i++) {

expect(rows[i].fameRate).to.be.at.least(300);

expect(rows[i].fameRate).to.be.at.most(800);

}

const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });

for (let i = 0; i < rows1.length; i++) {

expect(rows1[i].fameRate).to.be.at.least(600);

expect(rows1[i].fameRate).to.be.at.most(1000);

}

const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });

for (let i = 0; i < rows2.length; i++) {

Copilot · 2025-11-25T06:28:22Z

+        for (let i = 0; i < rows.length - 1; i++) {
+            expect(rows[i].fameRate).to.be.at.least(300);
+            expect(rows[i].fameRate).to.be.at.most(800);
+        }
+
+        const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });
+        for (let i = 0; i < rows1.length - 1; i++) {
+            expect(rows1[i].fameRate).to.be.at.least(600);
+            expect(rows1[i].fameRate).to.be.at.most(1000);
+        }
+
+        const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });
+        for (let i = 0; i < rows2.length - 1; i++) {


Off-by-one error in test: The loop condition i < rows2.length - 1 means the last element in the array is never tested for the fame rate filter. This should be i < rows2.length to ensure all users match the fame rate range.

Suggested change

for (let i = 0; i < rows.length - 1; i++) {

expect(rows[i].fameRate).to.be.at.least(300);

expect(rows[i].fameRate).to.be.at.most(800);

}

const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });

for (let i = 0; i < rows1.length - 1; i++) {

expect(rows1[i].fameRate).to.be.at.least(600);

expect(rows1[i].fameRate).to.be.at.most(1000);

}

const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });

for (let i = 0; i < rows2.length - 1; i++) {

for (let i = 0; i < rows.length; i++) {

expect(rows[i].fameRate).to.be.at.least(300);

expect(rows[i].fameRate).to.be.at.most(800);

}

const rows1 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 600, max: 1000 } });

for (let i = 0; i < rows1.length; i++) {

expect(rows1[i].fameRate).to.be.at.least(600);

expect(rows1[i].fameRate).to.be.at.most(1000);

}

const rows2 = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { fameRate: { min: 0, max: 0 } });

for (let i = 0; i < rows2.length; i++) {

Copilot · 2025-11-25T06:28:22Z

+            ${filters?.age ? `AND (CURRENT_DATE - u.born_at) / 365
+BETWEEN ${filters.age.min} AND ${filters.age.max}
+            ` : ''}
+            ${filters?.fameRate ? `AND u.fame_rate BETWEEN ${filters.fameRate.min} AND ${filters.fameRate.max}` : ''}


SQL injection vulnerability: Fame rate filter values are directly concatenated into the SQL query without parameterization. This creates a SQL injection risk. Use parameterized queries instead by adding these values to the parameters array.

Copilot · 2025-11-25T06:28:22Z

+    private fastify: FastifyInstance;
+    private userModel: UserModel;
+    private likeModel: LikeModel;
+    private viewModel: ViewModel


Missing semicolon: Line 44 is missing a semicolon at the end. While JavaScript allows this, it's inconsistent with the rest of the codebase which uses semicolons.

Suggested change

private viewModel: ViewModel

private viewModel: ViewModel;

Copilot · 2025-11-25T06:28:33Z

+        this.timeout(5000);
+
+        const { userData: data1, token: token1 } = await quickUser(app);
+        const { userData: data2, token: token2 } = await quickUser(app);


Unused variable data2.

Suggested change

const { userData: data2, token: token2 } = await quickUser(app);

Copilot · 2025-11-25T06:28:33Z

+
+        const { userData: data1, token: token1 } = await quickUser(app);
+        const { userData: data2, token: token2 } = await quickUser(app);
+        const { userData: data3, token: token3 } = await quickUser(app);


Unused variable data3.

Suggested change

const { userData: data3, token: token3 } = await quickUser(app);

const { token: token3 } = await quickUser(app);

Copilot · 2025-11-25T06:28:33Z

+        const { userData: data1, token: token1 } = await quickUser(app);
+        const { userData: data2, token: token2 } = await quickUser(app);
+        const { userData: data3, token: token3 } = await quickUser(app);
+        const { userData: data4, token: token4 } = await quickUser(app);


Unused variable data4.

Suggested change

const { userData: data4, token: token4 } = await quickUser(app);

const { token: token4 } = await quickUser(app);

Copilot · 2025-11-25T06:28:33Z

+        const { userData: data2, token: token2 } = await quickUser(app);
+        const { userData: data3, token: token3 } = await quickUser(app);
+        const { userData: data4, token: token4 } = await quickUser(app);
+        const { userData: data5, token: token5 } = await quickUser(app);


Unused variable data5.

Suggested change

const { userData: data5, token: token5 } = await quickUser(app);

const { token: token5 } = await quickUser(app);

Copilot · 2025-11-25T06:28:34Z

+            const totalScore = (ageScore * ageWeight) + (tagsScore * tagsWeight) + (fameRateScore * fameRateWeight) + (distanceScore * distanceWeight);
+            // console.log(`User ${user.id} - Age Score: ${ageScore.toFixed(2)}, Tags Score: ${tagsScore.toFixed(2)}, Fame Rate Score: ${fameRateScore.toFixed(2)}, Total Score: ${totalScore.toFixed(2)}, Distance Score: ${distanceScore.toFixed(2)}`);
+            scoreMap.set(user.id, totalScore);
+        })


Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).

Suggested change

})

});

YoungMame and others added 10 commits November 13, 2025 15:27

add:(idk)

dcc98d4

add:(filter and sort type)

4650499

add:(sorting [NOT TESTED])

7527f48

add:(sort by age)

eae2966

add:(sorting and filtering [TEST})

0764ab6

add:(classic sort function)

3d7e165

fix:(classic usert borwsing)

69488ff

add:([WIP]: browse users route)

d06bb1e

+

34a89ab

add:(orientation specification in browsing)

7da6081

Copilot AI review requested due to automatic review settings November 25, 2025 06:17

YoungMame linked an issue Nov 25, 2025 that may be closed by this pull request

Suggested profiles #50

Closed

4 tasks

Copilot started reviewing on behalf of YoungMame November 25, 2025 06:17 View session

Copilot finished reviewing on behalf of YoungMame November 25, 2025 06:19

YoungMame merged commit 11de3db into main Nov 25, 2025
6 checks passed

YoungMame deleted the 50-suggested-profiles branch November 25, 2025 06:20

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

50 suggested profiles#51

50 suggested profiles#51
YoungMame merged 10 commits into
mainfrom
50-suggested-profiles

YoungMame commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		const rows = await app.browsingService.browseUsers(data1.id as number, 10, 0, 50, { tags: ['music'] });

		for (let i = 0; i < rows.length - 1; i++) {

	for (let i = 0; i < rows.length - 1; i++) {
	for (let i = 0; i < rows.length; i++) {

	const { userData: data3, token: token3 } = await quickUser(app);
	const { token: token3 } = await quickUser(app);

	const { userData: data4, token: token4 } = await quickUser(app);
	const { token: token4 } = await quickUser(app);

	const { userData: data5, token: token5 } = await quickUser(app);
	const { token: token5 } = await quickUser(app);

Conversation

YoungMame commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants