add:(user research)

[YoungMame]

No description provided.

[Copilot]

Pull request overview

This PR adds a user research feature that allows users to search for other users by username while also applying the same filtering and sorting capabilities as the existing browsing feature.

Key changes:

• Added a new researchUsers endpoint that accepts a username parameter
• Modified the getUsersFromCoordsAndRadius method to support username filtering with parameterized SQL queries
• Added comprehensive test coverage for the username research functionality

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
fastify/assets/test/integration/ws/browsing.test.ts	Removed unused import and added test case for username research functionality
fastify/assets/srcs/services/BrowsingService.ts	Modified private method to accept username parameter and added new public researchUsers method with ILIKE filtering
fastify/assets/srcs/routes/private/research/index.ts	Created new research route with schema validation for username-based user search
fastify/assets/srcs/routes/private/index.ts	Registered the new research routes under /research prefix
fastify/assets/srcs/controllers/private/research/index.ts	Implemented controller handler for research endpoint with parameter processing
fastify/assets/@types/fastify.d.ts	Added TypeScript definitions for the new researchUsers method

Comments suppressed due to low confidence (1)

fastify/assets/srcs/services/BrowsingService.ts:253

• The researchUsers method duplicates most of the logic from browseUsers (lines 187-218). Consider extracting the common logic into a shared private method to reduce code duplication and improve maintainability.

    public async researchUsers(userId: number, username: string, limit: number = 5, offset: number = 0, radius: number = 25, filters?: BrowsingFilter, sort?: BrowsingSort): Promise<Array<BrowsingUser>> {
        const user = await this.fastify.userService.getMe(userId);
        const lat = filters?.location?.latitude ?? user.location?.latitude;
        const lng = filters?.location?.longitude ?? user.location?.longitude;
        if (filters?.tags && filters.tags.length === 0) {
            delete filters.tags;
        }
        const bornAt = user.bornAt;
        const fameRate = user.fameRate;
        const tags = user.tags;

        if (lat === undefined || lng === undefined)
            throw new BadRequestError();
        let gender: string | undefined = undefined;
        if (user.orientation === 'heterosexual') {
            gender = user.gender === 'men' ? 'women' : 'men';
        } else if (user.orientation === 'homosexual') {
            gender = user.gender;
        }
        const userRows = await this.getUsersFromCoordsAndRadius(userId, username, lat, lng, limit, offset, radius, gender, filters);
        switch (sort) {
            case 'distance':
                return this.sortByDistance(userRows);
            case 'age':
                return this.sortByAge(userRows, bornAt);
            case 'fameRate':
                return this.sortByFameRate(userRows);
            case 'tags':
                return this.sortByTags(userRows, tags);
            default:
                return this.sortByAll(userRows, bornAt, tags, fameRate ?? 0);
        }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Debug console.log statement should be removed before merging to production. This appears to be leftover debugging code.

Suggested change

console.log('Username in researchUsersHandler:', username);

[Copilot]

The username parameter is being used with ILIKE and wildcards, which could be exploited for SQL injection if the username contains special characters like %, _, or . Consider sanitizing the username to escape these special SQL LIKE wildcard characters before adding the % wildcards.

[Copilot]

Unused variable data2.

Suggested change

	const { userData: data2, token: token2 } = await quickUser(app);
	const { token: token2 } = await quickUser(app);

[Copilot]

Unused variable data3.

Suggested change

	const { userData: data3, token: token3 } = await quickUser(app);
	const { token: token3 } = await quickUser(app);