fix: compare included files with path semantics - #639
Draft
vortsghost2025 wants to merge 2 commits into
Draft
vortsghost2025 wants to merge 2 commits into
vortsghost2025 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638.
Problem
On Windows, wildcard (
"*") schema generation can silently return an emptydefinitionsobject whengloband TypeScript represent the same source path with different separators.Observed for the same file:
buildGenerator()currently uses exact string membership, which can leaveuserSymbolsempty even though named symbols remain available.Fix
Use the existing
pathEqual()helper:The library already uses
pathEqual()for a related comparison ingetMainFileSymbols().Regression test
Adds a focused test using opposite slash styles for the same source file and verifies that it is still classified as a user/main-file source.
No workflow or schema-tooling changes.
Windows validation
Validated while investigating modelcontextprotocol/modelcontextprotocol#3114 with typescript-json-schema 0.68.0.
Fresh Windows generation after this one-line fix produced:
The regenerated schema files had no diff from the checked-in schemas.
Example validation: