fix(discovery): exclude build-wrapper infra paths in git-mode - #2
Open
sorted-ai-bot wants to merge 1 commit into
Open
sorted-ai-bot wants to merge 1 commit into
sorted-ai-bot wants to merge 1 commit into
Conversation
Git-mode discovery (git ls-files) did not apply the build-wrapper and infrastructure exclusions that walk-mode applied, so files under .mvn/wrapper, gradle/wrapper, vendor, node_modules, .git, and .gradle were scanned and reported as false positives (e.g. a vendored Maven wrapper main class flagged as dead code). Extract the exclusion predicate into a shared isExcludedInfraPath helper and apply it in both git-mode and walk-mode so the two discovery paths are symmetric. Matching is by exact path segment (a project literally named e.g. mvnutil is not excluded). Adds discovery_test.go covering both excluded and not-excluded cases and an integration test for each discovery path. Verified: spring-boot-docker FP cleared (0 findings); genuine true positives preserved (spring-boot-rest-example 2, spring-petclinic 0); build/vet/test green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git ls-files) did not apply the build-wrapper / infrastructure directory exclusions that walk-mode applied. As a result, files under.mvn/wrapper,gradle/wrapper,vendor,node_modules,.git, and.gradlewere scanned in real (git-tracked) projects and reported as false positives — e.g. a vendored Maven wrapper main class flagged as dead code.findJavaFilesWalk;findJavaFilesGitfiltered solely by path prefix. Asymmetry between the two discovery paths.isExcludedInfraPathhelper and apply it in BOTH discovery paths so they are symmetric. Matching is by exact path SEGMENT (a project literally named e.g.mvnutilormygradlestuffis NOT excluded; awrapperdir is excluded only when its parent isgradle).discovery_test.go: table-driven unit tests for excluded vs not-excluded paths, plus an integration test for each discovery path (walk and git).Verification
spring-boot-docker: 3 false positives → 0 findings.spring-boot-rest-examplestill 2 (a never-published Spring event),spring-petclinicstill 0.go build ./... && go vet ./...green; new discovery tests pass.This is a precision fix on the read-only Java scanner. No behavior change for application projects that were already clean.