Conversation
- pnpm overrides for js-yaml, qs, joi, fast-uri, fflate, colord, baseline-browser-mapping, svgo, browserslist, toml and @swc/html. - Re-resolve svgo, fast-uri and joi, whose older open-ended overrides had kept vulnerable versions in the lockfile. - ci.yml: explicit read-only permissions (code scanning alert #138). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes all 20 open Dependabot alerts and code scanning alert #138.
Triage. None of the alerts is exploitable on this site in practice:
fflatereaches the browser (through three-stdlib and jspdf). Its advisory is an infinite loop on a malformed ZIP, which can only hang the user's own tab.So no issues were opened; everything is fixed here.
Lockfile note.
svgo,fast-uriandjoiwere already covered by older, open-ended overrides such assvgo@>=3.0.0 <3.3.3 → >=3.3.3. The lockfile had kept the version first resolved under them, so these three were re-resolved.toml3 → 4. It is only imported byremark-mdx-frontmatter, which uses the namedparseexport. That export still exists in v4 (checked).ci.yml. Addspermissions: contents: read, since the job only reads the repository (code scanning #138).Remaining.
pnpm auditstill reports only the twoimage-sizeadvisories. They have no patched release, and they were dismissed earlier because the package is only used at build time.Verification
pnpm install --frozen-lockfilesucceeds.pnpm typecheckpasses;pnpm linthas 0 errors.pnpm test:db: 43/43.DOCUSAURUS_ONBROKENLINKS=throw pnpm buildsucceeds for all six locales./mini-games/eco-sort-game/(three.js / drei, which pull in fflate) both render./_vercel/*analytics scripts, which exist only on Vercel.🤖 Generated with Claude Code