feat: Include Moon and Majora Mask Requirements#120
Merged
PhlexPlexico merged 11 commits intodevfrom Mar 2, 2026
Merged
Conversation
This also includes a new setting to skip the giants cutscene on the roof as well. Moved over related entrance patches to their own patches and hooks assembly files.
… expand to other victory conditions later.
…to remains given.
PhlexPlexico
changed the title
Update various calls into actor list now. Update asm call to be more definitive of what it actually does. Add more debugging context for cycle flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new options have been included in settings for app side.
masksNeededToEnterMoonandmasksNeededForVictory. The latter could be a temporary setting as we look into more victory conditions and increase complexity on this check, but for now we can adjust the remains from 1-4 for each check, allowing for earlier moon checks.This change also includes a new option to skip the Giant's Cutscene when Oath to Order is played (
skipGiantsCutscene).The clock tower text generated on the app side should include how many masks are required to get to the Moon, while the new text ID (
0x6144) should include how many remains are required if the requirements are not yet met. The Moon Child also remains to have default behaviour to take off any mask before talking to him.Adjusts Giant's Cutscene to ensure that 4 Giants are showing if we have met requirements, otherwise it will show the amount that you have for the remains you acquired.