docs: correct stale HANDOFF known-issue, document actual security posture - #11
Merged
Merged
Conversation
…rer sandbox fix - Remove 'Recovery window hardening' entry — that vulnerability does not exist in the codebase. main.desktop.js has one BrowserWindow, already hardened (nodeIntegration: false, contextIsolation: true, sandbox: true). - Add real findings from fix/recovery-window-hardening (NeuralOS_Master_Build PR #6): * main.xxxplorer.js: sandbox: true now explicit (was relying on Electron default) * preload.js: postMessage targetOrigin '*' explained — cannot narrow to 'file://' due to null opaque origin on file:// pages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodeIntegration: true/contextIsolation: false/sandbox: falsedoes not exist inmain.desktop.js. The single window there is fully hardened.fix/recovery-window-hardening):main.xxxplorer.jsnow has explicitsandbox: truepreload.jspostMessage'*'documented with explanation of thefile://opaque-origin constraintNo code changes
Docs only. Corrects inaccurate security state in HANDOFF.
🤖 Generated with Claude Code