Expose Congress.gov measure details in voting records - #110
Merged
Conversation
Signed-off-by: capituwuistgoonsquad <ultimamaster13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0037_congress_gov_measure_read_surface.sqlwith a versionedget_canonical_voting_records_v3RPCData and security boundary
source_records,legislative_roll_calls,legislative_measures, and link tables remain private to browser rolesProduction evidence
The first scheduled run after PR #109, run 32090695651, confirmed zero legacy GovTrack profile attempts/failures while the official House, Senate, and Congress.gov paths remained healthy. The previously observed Congress.gov contract remains 18 detail calls, 18 measures, 43 exact links, and 40 linked roll calls.
Validation
python3 -m unittest discover -s tests -q— 371 tests passedpython3 -m compileall -q .npm run typechecknpm run lintALLOW_MOCK_BUILD=true npm run build— static export succeededgit diff --checkRequired post-merge rollout
migrations/0037_congress_gov_measure_read_surface.sqlto Supabase before the next scheduled scraper. Do not replay earlier migrations.anonandauthenticated.Until step 1 is complete, the frontend remains available through the narrow v2 rollout fallback, but scraper schema preflight intentionally blocks the next ETL run so schema drift cannot silently persist.
Greptile Summary
This change adds a versioned voting-record response that decorates official vote rows with bounded Congress.gov measure details and displays them in the Voting Record tab. The client preserves the existing v2 fallback while the new database migration is unavailable.
The executed client harness disproved the tested failure hypotheses: v3 measure decoration did not alter vote-row pagination, legacy vote rows remained undecorated, malformed and duplicate measures were discarded, and unsafe URLs were not rendered. Focused migration, UI, schema-preflight, TypeScript, lint, and production fixture-build checks also completed successfully.
T-Rex validation blocked
Live Supabase validation was blocked by missing approved remote
SUPABASE_URLandSUPABASE_KEYcredentials and a representative profile UUID. As a result, deployed v3/v2 result equivalence, browser-role access controls, and live House/Senate rendering could not be exercised.Confidence Score: 5/5
No actionable defects were found in the exercised migration, client normalization, fallback, UI build, and schema-preflight behavior.
There are no final findings. The focused runtime harness exercised the changed v3/v2 client boundary, pagination, legacy-row isolation, measure validation, and URL sanitization, while focused contract tests and frontend checks passed.
Files Needing Attention: No files require changes from this review.
migrations/0037_congress_gov_measure_read_surface.sqland the live Supabase deployment should receive the planned post-deployment v3/v2 and browser-role verification once approved credentials are available.What T-Rex did
Reviews (1): Last reviewed commit: "Expose Congress.gov measure details" | Re-trigger Greptile