Skip to content

network: fix GetFreeIp limit across multiple ranges - #34

Open
tllovesxs wants to merge 1 commit into
ZSvirt:mainfrom
tllovesxs:codex/fix-get-free-ip-limit
Open

tllovesxs wants to merge 1 commit into
ZSvirt:mainfrom
tllovesxs:codex/fix-get-free-ip-limit

Conversation

@tllovesxs

Copy link
Copy Markdown
Contributor

Summary

  • Fix the remaining GetFreeIp limit calculation across multiple IP ranges.
  • Stop processing once the remaining limit is zero, including limit=0.

Fixes #29.

Test plan

  • git diff --check
  • Review the multi-range path in L3BasicNetwork.handle(APIGetFreeIpMsg).
  • The full integration test requires the project test environment (database and simulator), so it was not run locally.

Copilot AI lite review requested due to automatic review settings September 11, 2026 05:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@zsphere-opensource

Copy link
Copy Markdown
Contributor

Thanks for the detailed report and the proposed fix.
The change appears to address the remaining-limit calculation across multiple IP ranges. We’ll evaluate the implementation and validate the relevant behavior through our internal review process, including IPv4, IPv6, and multiple-range cases.
If the validation passes and the change is approved, we’ll integrate it through our internal GitLab workflow and synchronize the accepted commit back to the public repository while preserving your authorship.
We’ll update this PR after the evaluation is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ZSvirt] bug: GetFreeIp returns fewer addresses across multiple IP ranges

3 participants