Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a
204branch toZSClient.writeApiResultso a204 No Contentresponse is treated as a successful empty result instead of falling through to
the
unknown status codeexception.Why the change is needed
doCallalready treats200 || 204as success and callswriteApiResultforboth. Because
writeApiResultonly handled200and503, a204responsewould throw
ApiException("unknown status code: 204"), turning a successfulcall into an error.
How the change was tested
Incremental one-branch addition; compiles cleanly. Not verified against a
running server.
Related issues
Fixes #52
Compatibility / upgrade impact
None — only adds handling for a previously unhandled success status code.