Open
Conversation
iccowan
force-pushed
the
863-impersonation-implementation
branch
from
0575ac9 to
302d9fc
Compare
iccowan
force-pushed
the
863-impersonation-implementation
branch
from
302d9fc to
392c9b0
Compare
kjporter
reviewed
Feb 23, 2026
kjporter
reviewed
Feb 23, 2026
kjporter
reviewed
Feb 23, 2026
kjporter
reviewed
Feb 23, 2026
| Route::get('/', 'AdminDash@backgroundMonitor'); | ||
| }); | ||
|
|
||
| Route::prefix('impersonation')->middleware('toggle:impersonation')->group(function () { |
Contributor
There was a problem hiding this comment.
Why not guard the entire impersonation route? Is there a reason that start is guarded but stop is not? Trying to think if there is any way that the stop route could expose an attack vector...
Member
Author
There was a problem hiding this comment.
Stop can't be guarded because the middleware has to run on the impersonated user. If we don't allow stop to be hit by all users, we would never be able to end impersonation on non-privileged users.
Contributor
|
QA fail - looks like you are missing a migration to add the |
iccowan
force-pushed
the
863-impersonation-implementation
branch
from
392c9b0 to
ec3d260
Compare
Member
Author
Corrected and merged into d9bc82a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
impersonation