Skip to content

feat: BSC uni, sushi, pancake & curve added - #2

Open
Aviksaikat wants to merge 3 commits into
Zacholme7:mainfrom
Aviksaikat:feat/bsc
Open

feat: BSC uni, sushi, pancake & curve added#2
Aviksaikat wants to merge 3 commits into
Zacholme7:mainfrom
Aviksaikat:feat/bsc

Conversation

@Aviksaikat

Copy link
Copy Markdown

Summary

  • feat: BSC uni, sushi, pancake & curve added.
  • fix: syntax formatted with cargo fmt.
  • docs: updated usage in readme fix: Example usage fixed #1

@Zacholme7

Zacholme7 commented Oct 31, 2024

Copy link
Copy Markdown
Owner

Cool, thanks for opening this. Ill give it a review and test.

I dont run a BSC node, have you tested a sync and confirmed number of pools looks accurate?

Been doing a lot of iteration and debugging some potential issues right now, so there is potential the current head is not stable for v3 state but the addresses should be fine.

@Aviksaikat

Copy link
Copy Markdown
Author

Cool, thanks for opening this. Ill give it a review and test.

I dont run a BSC node, have you tested a sync and confirmed number of pools looks accurate?

Been doing a lot of iteration and debugging some potential issues right now, so there is potential the current head is not stable for v3 state but the addresses should be fine.

Actually I have tested with only infura(paid one) which looked good lots of 429. I have BSC a fast node running. I'll test against it

@Zacholme7

Copy link
Copy Markdown
Owner

Was the rate limit set properly for the infura link? I have been able to sync on public alchemy endpoint after setting rate limit properly (took a very long time though). I will try a public BSC endpoint too.

But yes please try local if possible to confirm.

@Aviksaikat

Copy link
Copy Markdown
Author

@Zacholme7 I'm getting called Result::unwrap()on anErr value: Failed to create or open cache file: cache/Ethereum_UniswapV2_cache.json

@Aviksaikat

Copy link
Copy Markdown
Author

I think it's a bug in the main repo. Just tried with the latest release

@Zacholme7

Copy link
Copy Markdown
Owner

@Zacholme7 I'm getting called Result::unwrap()on anErr value: Failed to create or open cache file: cache/Ethereum_UniswapV2_cache.json

This is something that is on my todo list to fix. You can get around it by running ulimit -n 4000

@Aviksaikat

Copy link
Copy Markdown
Author

image
Alright so it's working

@iht76

iht76 commented Nov 2, 2024

Copy link
Copy Markdown

can algebra pools be added too?

@Zacholme7

Copy link
Copy Markdown
Owner

image Alright so it's working

Great! ill get this merged in. Planning to do another release by end of weekend.

@Zacholme7

Copy link
Copy Markdown
Owner

can algebra pools be added too?

yep! it looks like it is not a direct fork of v2/v3, so you would have to define a new pool structure and corresponding contract. This is still a process I am working on finalizing and making it easier to do/understand though.

@Aviksaikat

Copy link
Copy Markdown
Author

what's the update on this ?

@Aviksaikat

Copy link
Copy Markdown
Author

@Zacholme7 can we merge this one first ?

@Zacholme7

Copy link
Copy Markdown
Owner

@Zacholme7 can we merge this one first ?

Hi, sorry ive been ironing out some bugs first and made a decent amount of changes so I was waiting on this. Can you merge main and add the curve addresses to pools/pool_builder.rs? Then this is good to go. Thanks

@Aviksaikat

Copy link
Copy Markdown
Author

hey any update on this one @Zacholme7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants