ci: add license deny list to dependency review#65
Conversation
Deny AGPL-3.0, SSPL-1.0, EUPL-1.1, EUPL-1.2, CPAL-1.0, and Watcom-1.0 licenses in new dependencies.
📝 WalkthroughWalkthroughThis PR adds a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/dependency-review.yml (1)
20-21:deny-licensesis deprecated in the upstream actionAt Line 21, this works today, but
actions/dependency-review-actiondocumentsdeny-licensesas deprecated and potentially removable in the next major version. Consider migrating policy to a non-deprecated approach (typically an explicitallow-licensespolicy, optionally viaconfig-file) before future upgrades.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/dependency-review.yml around lines 20 - 21, The workflow uses the deprecated deny-licenses input (deny-licenses) for actions/dependency-review-action; replace it by switching to an explicit allowlist or a config-file policy. Update the job step that currently sets deny-licenses to instead provide either an allow-licenses list (allow-licenses) with the approved SPDX identifiers or point the action to a dependency-review config file (config-file) that defines license policy, ensuring the input name and payload match the upstream action's current docs and remove the deprecated deny-licenses entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/dependency-review.yml:
- Around line 20-21: The workflow uses the deprecated deny-licenses input
(deny-licenses) for actions/dependency-review-action; replace it by switching to
an explicit allowlist or a config-file policy. Update the job step that
currently sets deny-licenses to instead provide either an allow-licenses list
(allow-licenses) with the approved SPDX identifiers or point the action to a
dependency-review config file (config-file) that defines license policy,
ensuring the input name and payload match the upstream action's current docs and
remove the deprecated deny-licenses entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 55a4c293-adb3-4a45-94e2-7be194fdb9e9
📒 Files selected for processing (1)
.github/workflows/dependency-review.yml
Summary
deny-licensesto dependency-review-actionPRs introducing dependencies under these licenses will be blocked.
Summary by CodeRabbit