-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(api): add global UI events #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a30256c
feat(api): add global UI events
wizzomafizzo 8d778e4
fix(mac): remove stale time import
wizzomafizzo 9f395c6
test(ui): cover event lifecycle edge cases
wizzomafizzo 2234e31
fix(ui): harden event delivery and cancellation
wizzomafizzo 961f422
test(ui): strengthen dependency boundary coverage
wizzomafizzo f0c379b
fix(ui): serialize picker responses and cancel completion watcher
wizzomafizzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Zaparoo Core | ||
| // Copyright (c) 2026 The Zaparoo Project Contributors. | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| // | ||
| // This file is part of Zaparoo Core. | ||
| // | ||
| // Zaparoo Core is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // Zaparoo Core is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with Zaparoo Core. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package methods | ||
|
|
||
| import ( | ||
| "errors" | ||
|
|
||
| "github.com/ZaparooProject/zaparoo-core/v2/pkg/api/models" | ||
| "github.com/ZaparooProject/zaparoo-core/v2/pkg/api/models/requests" | ||
| "github.com/ZaparooProject/zaparoo-core/v2/pkg/api/validation" | ||
| ) | ||
|
|
||
| var errUIServiceUnavailable = errors.New("UI event service is unavailable") | ||
|
|
||
| //nolint:gocritic // single-use parameter in API handler | ||
| func HandleUI(env requests.RequestEnv) (any, error) { | ||
| if env.UI == nil { | ||
| return nil, errUIServiceUnavailable | ||
| } | ||
| return env.UI.State(), nil | ||
| } | ||
|
|
||
| //nolint:gocritic // single-use parameter in API handler | ||
| func HandleUIRespond(env requests.RequestEnv) (any, error) { | ||
| if env.UI == nil { | ||
| return nil, errUIServiceUnavailable | ||
| } | ||
|
|
||
| var params models.UIRespondParams | ||
| if err := validation.ValidateAndUnmarshal(env.Params, ¶ms); err != nil { | ||
| return nil, models.ClientErrf("invalid params: %w", err) | ||
| } | ||
| if err := env.UI.Respond(params.ID, params.Action, params.ChoiceID); err != nil { | ||
| return nil, models.ClientErrf("UI response failed: %w", err) | ||
| } | ||
| return NoContent{}, nil | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.